refactor: remove dynamic_deps feature #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is broken because of the way directories are layed out. When we run the tool we have The custom module loader only looks under the runfiles. |
This isn't the right way to declare that a rule depends on a plugin. - It is too hard for users to understand what this means, how to configure it correctly, and to discover that their broken tool needs a dynamic dep. - It is not npm-idiomatic. The dependency graph at install time is not meant to reflect the actual dependencies that will be loaded at runtime. In the rollup example, the `rollup.config.js` has `import 'rollup-plugin-json'` so the corresponding BUILD file should have that package in the deps. BREAKING CHANGE: The dynamic_deps attribute of yarn_install and npm_install is removed, in favor of declaring needed packages in the deps/data of the rule that invokes the tool.
alexeagle
force-pushed
the
rm_dynamic_deps
branch
from
84a7381
to
2bf735b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the right way to declare that a rule depends on a plugin.
configure it correctly, and to discover that their broken tool needs a
dynamic dep.
meant to reflect the actual dependencies that will be loaded at runtime.
In the rollup example, the
rollup.config.jshasimport 'rollup-plugin-json'so the corresponding BUILD file should have that package in the deps.
BREAKING CHANGE:
The dynamic_deps attribute of yarn_install and npm_install is removed,
in favor of declaring needed packages in the deps/data of the rule that
invokes the tool.